]> dgit.raspbian.org Git - kamailio.git/commitdiff
ims_ocs: Free after copying the values
authorXenofon Karamanos <xk@gilawa.com>
Tue, 31 Mar 2026 10:52:11 +0000 (10:52 +0000)
committerVictor Seva <vseva@debian.org>
Tue, 8 Sep 2026 21:48:12 +0000 (23:48 +0200)
- Remove extra freeavplist call
- Add len check

(cherry picked from commit a56942affd35d41890c23f1d3b5bb519f87ef5ad)

Gbp-Pq: Topic upstream
Gbp-Pq: Name ims_ocs-Free-after-copying-the-values.patch

src/modules/ims_ocs/ocs_avp_helper.c

index f350a79a12ba48371944ba83705d7363276ad38d..378b2a209bc4f6268953454aa9fd65cdc691b49b 100644 (file)
@@ -208,8 +208,7 @@ int getUnits(AAAMessage *msg, int *used, int *service, int *group)
                        list2 = cdp_avp->cdp->AAAUngroupAVPS(req_units->data);
                        value = cdpb.AAAFindMatchingAVPList(
                                        list2, list2.head, AVP_CC_Time, 0, 0);
-                       cdpb.AAAFreeAVPList(&list2);
-                       if(value)
+                       if(value && value->data.len >= 4)
                                units = get_4bytes(value->data.s);
                        cdpb.AAAFreeAVPList(&list2);
                }